C++20 compatible polyfill for <expected>
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
added
c++20
Bronek
force-pushed
the
expected_polyfill
branch
from
e6a5344 to
acdd08e
Compare
Bronek
changed the title
<expected>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bronek
force-pushed
the
expected_polyfill
branch
from
3971917 to
1ec1b3a
Compare
Bronek
force-pushed
the
expected_polyfill
branch
4 times, most recently
from
950a56f to
f01699f
Compare
Bronek
force-pushed
the
expected_polyfill
branch
8 times, most recently
from
7bdf1fd to
e2cf86f
Compare
Bronek
force-pushed
the
expected_polyfill
branch
from
dee101b to
aae61bc
Compare
Bronek
force-pushed
the
expected_polyfill
branch
from
63ad1c2 to
c07a178
Compare
Bronek
force-pushed
the
expected_polyfill
branch
4 times, most recently
from
ec17c49 to
25dbf14
Compare
Bronek
force-pushed
the
expected_polyfill
branch
from
25dbf14 to
afdb9dc
Compare
a1q123456
reviewed
Aug 4, 2025
a1q123456
reviewed
Aug 4, 2025
|
LGTM |
godexsoft
reviewed
Aug 5, 2025
godexsoft
reviewed
Aug 5, 2025
godexsoft
reviewed
Aug 5, 2025
godexsoft
approved these changes
Aug 5, 2025
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
I left a couple of questions/suggestions but none are a blocker imo 👍
Member
Author
|
@atomgalaxy would you be able to check the |
Bronek
force-pushed
the
expected_polyfill
branch
from
0a65557 to
39ba16a
Compare
Bronek
force-pushed
the
expected_polyfill
branch
from
39ba16a to
e1840f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a major blocker for C++20 compatibility by providing a polyfill for
<expected>header which will work in C++20 compilation mode with older compilers e.g. gcc 12, clang 16 or Visual Studio 2022.This is meant to be full implementation of https://eel.is/c++draft/expected , along with extensive unit tests.