Skip to content

Conversation

@luandro
Copy link
Contributor

@luandro luandro commented Apr 2, 2025

This is a re-write of Pirania using nftables, still WIP.

Must haves:

  • Open captive portal with Internet
  • Block access to Internet
  • Permit access to local network
  • Working whitelist of macs
  • Working whitelist of ips
  • Working blocklist of ips
  • Working with Ubus
  • Working with LimeApp

@ilario
Copy link
Member

ilario commented Apr 4, 2025

Looks amazing :D
Compiling an image with this code and OpenWrt 24.10, I observed this warning message:
WARNING: Makefile 'package/feeds/libremesh/pirania/Makefile' has a dependency on 'liblucihttp0', which does not exist
Seems that from the buildroot point of view, that package is named liblucihttp instead of liblucihttp0.

@ilario
Copy link
Member

ilario commented Jun 11, 2025

Compiling an image with this code and OpenWrt 24.10, I observed this warning message: WARNING: Makefile 'package/feeds/libremesh/pirania/Makefile' has a dependency on 'liblucihttp0', which does not exist Seems that from the buildroot point of view, that package is named liblucihttp instead of liblucihttp0.

I looked into this: the package is named liblucihttp and is pulled as a dependency of liblucihttp-lua, but there is an ABI_VERSION:=0 thing in the Makefile that causes the 0 to be appended to the package name.

https://github.com/openwrt/luci/blob/d1269d63dae00a0d3611d740bcd1fc77a48f5876/contrib/package/lucihttp/Makefile#L22-L26

So, that warning message seems to be erroneous and everything is actually ok. Is this correct @jow- ?

@jow-
Copy link

jow- commented Jun 11, 2025

The source level dependency should be just +liblucihttp - buildroot will take care of turning it into Depends: liblucihttp0 automatically in binary package metadata.

@ilario
Copy link
Member

ilario commented Jun 17, 2025

The source level dependency should be just +liblucihttp - buildroot will take care of turning it into Depends: liblucihttp0 automatically in binary package metadata.

Thanks!!!! I did not see that there was also an explicit dependency from liblucihttp0 in the Makefile!

@catuaba07
Copy link

catuaba07 commented Aug 31, 2025

Adding discovered issues:
1- when enabling portal by limeapp, it does not persiste
image

2- starting it from console shows an error and it starts to block internet. If voucher system is not enabled, is expected to show captive portal and not to block internet access

# captive-portal start
Command failed: Not found
Failed to parse json data: unexpected end of data

@ilario ilario mentioned this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants