Compile fix for libnx 4.9.0. Update mmap with the new virtmem API. #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently set up a development environment to build RetroArch for Switch. I could not compile this core so I looked into it and made a compile fix for the latest version if you consider updating to that. I don't know which libnx version is supposed to be used to compile the current develop.
This affects the the DynaRec compiler that I am not too familiar with but because it wants to allocate executable memory I picked an appropriate alloc routine for that. I have tested it with OoT and Banjo-Kazooie (previously uncompiled) and they ran without crashes but no longer sessions yet.