Add SM4 block cipher [reboot] #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
2 times, most recently
from
ba77a47 to
6368281
Compare
Collaborator
Author
|
I believe this is ready for review |
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
6368281 to
b45ecee
Compare
Collaborator
Author
|
All fixups squashed too |
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
b45ecee to
4e198ef
Compare
Collaborator
Author
|
Hmmmm, coveralls says that only 1 line in the new code is covered... huh??? |
Member
oopsie :D race condition on the cipher ID with the addition of DES-X via #587 😬 |
sjaeckel
reviewed
Aug 21, 2024
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
4e198ef to
0de6216
Compare
sjaeckel
requested changes
Aug 26, 2024
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
0de6216 to
0db8b7a
Compare
Member
|
What do you think of those |
sjaeckel
approved these changes
Aug 29, 2024
sjaeckel
force-pushed
the
ChaoWeiAtGit/develop
branch
from
7518c4c to
8312ed1
Compare
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
8312ed1 to
7b26360
Compare
Collaborator
Author
|
They are all fine, so I adopted (squashed) them all |
SM4 (formerly SMS4)[1] is a block cipher used in the Chinese National Standard for Wireless LAN WAPI (Wired Authentication and Privacy Infrastructure). --from wikipedia
levitte
force-pushed
the
ChaoWeiAtGit/develop
branch
from
7b26360 to
6f15a45
Compare
Collaborator
Author
|
Now also rebased on a fresher develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SM4 (formerly SMS4)[1] is a block cipher used in the Chinese
National Standard for Wireless LAN WAPI (Wired Authentication
and Privacy Infrastructure).
--from wikipedia
Checklist
This is a reboot of #457, which seems to have been abandoned by its author