Minor improvements #704
Open
Minor improvements #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
... in order of likelihood of usage and/or strength. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Only go once through `X_descriptor[]` when calling `register_X()` Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Before this patch it silently didn't work, now it errors out. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
The NULL is optional. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This reverts commit 93f5348. You should use the CMake flag `-DCMAKE_CXX_COMPILER_LAUNCHER=ccache` instead. Sibling-to: libtom/libtommath#577 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This closes #354 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Change the default behavior of `LTC_ARGCHK()` for Release, resp. Release+Shared Library builds to be non-fatal. This closes #458 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
One can now define them on a per-case basis to disable them. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
It expects a pair of type `(unsigned char*,unsigned long)` and not `(unsigned char*,unsigned int)`. Fixes: 46fa363 ("Finish up RFC6979 ECDSA keygen") Reported-via: #699 (comment) ff. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
```
src/ciphers/aes/aesni.c:150:7: warning: Value stored to 'temp' is never read [deadcode.DeadStores]
150 | temp = temp_invert(rk);
| ^ ~~~~~~~~~~~~~~~
1 warning generated.
```
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This can be disabled by defining `LTC_NO_AES_NI`. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Fixes: fe8e4bf ("Use more builtin functions if available") Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
With `LTC_FAST` enabled test to read from different offsets. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This also enables testing of PKCS#8 keys using modern hash algos with LTC_EASY. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Related to #349 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* The oldest supported Ubuntu Version is 22.04 which comes with CMake 3.22. * Refactor demos/CMakeLists.txt to set the list of binaries only once. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've broken out some less discussion-worthy parts of #699 into this PR, in order to speed up the review process.