-
Notifications
You must be signed in to change notification settings - Fork 1
LPD-72494 Delete Poshi tests #5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-38 |
|
|
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1553. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-72494 1 Failed Jobs:For more details click here.format-source-files:
[java] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[java] SLF4J: Defaulting to no-operation (NOP) logger implementation
[java] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[java] java.lang.Exception: Found 4 formatting issues:
[java] 1: Test dependencies file "/opt/dev/projects/github/liferay-portal/portal-web/test/functional/com/liferay/portalweb/dependencies/font_family.css" is only referenced by one module, move it to module dependencies directory: ./portal-web/test/functional/com/liferay/portalweb/tests/enduser/frontendinfrastructure/uiinfrastructure/remotewebapps/ClientExtension.testcase (SourceCheck:PoshiDependenciesFileLocationCheck)
[java] 2: Test dependencies file "/opt/dev/projects/github/liferay-portal/portal-web/test/functional/com/liferay/portalweb/dependencies/font_family.css" is only referenced by one module, move it to module dependencies directory: ./portal-web/test/functional/com/liferay/portalweb/tests/enduser/frontendinfrastructure/uiinfrastructure/remotewebapps/ClientExtensionJSImportMap.testcase (SourceCheck:PoshiDependenciesFileLocationCheck)
[java] 3: Test dependencies file "/opt/dev/projects/github/liferay-portal/portal-web/test/functional/com/liferay/portalweb/dependencies/font_family.css" is only referenced by one module, move it to module dependencies directory: ./portal-web/test/functional/com/liferay/portalweb/tests/enduser/frontendinfrastructure/uiinfrastructure/remotewebapps/ClientExtensionThemeSvg.testcase (SourceCheck:PoshiDependenciesFileLocationCheck)
[java] 4: Test dependencies file "/opt/dev/projects/github/liferay-portal/portal-web/test/functional/com/liferay/portalweb/dependencies/font_family.css" is only referenced by one module, move it to module dependencies directory: ./portal-web/test/functional/com/liferay/portalweb/tests/enduser/frontendinfrastructure/uiinfrastructure/usecase/UIInfrastructureUsecase.testcase (SourceCheck:PoshiDependenciesFileLocationCheck)
[java]
[java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:476)
[java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:303)
[stopwatch] [run.batch.test.action: 2:08.138 sec]
[echo] The following error occurred while executing this line: |
|
Jenkins Build:test-portal-source-format#6860 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5208 Testray Routine:EE Pull Request Testray Build ID: 377746093Testray Importer:test-portal-source-format#6860 |
|
Hi @baharturk , thanks for your contribution. Apparently, SF is not happy with a css file that is referenced now from only one place. I have no idea about this error. Did you experience any similar case in the past? |
Hi @dsanz, it's first time I'm seeing this error, too, I wasn't sure how to fix it. Should I open a thread in CI channel? |
|
Hi @baharturk , please let me know if you need help with this, according to the conversation we've had in slack. Thanks a lot |
|
ci:test:sf |
|
Test suite sf has been triggered on http://test-1-31 |
|
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1554. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-72494 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#8556 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5208 Testray Routine:EE Pull Request Testray Build ID: 383738091Testray Importer:test-portal-source-format#8556 |
|
Hi @dsanz, sf passed, you can proceed as needed. Thanks! |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites:
|
|
Test suite default has been triggered on http://test-1-40 |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#168396 |
Hello, I'm sending this pull to delete the Poshi tests that where decided to be deleted in the sheet.
https://liferay.atlassian.net/browse/LPD-72494
cc/ @dsanz