Skip to content

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Sep 2, 2024

See #701.

Early state, probably should get at least a README. The code is pretty much a verbatim copy of https://github.com/jeremyrsmith/mima-cli/ (licensed under Apache 2.0, I'm not sure what the preferred protocol is for adding a notice here).

@kubukoz
Copy link
Contributor Author

kubukoz commented Apr 14, 2025

@SethTisue can we revive this? Hate to see this go to waste :)

@SethTisue
Copy link
Collaborator

sure. let's see if CI likes it

@SethTisue
Copy link
Collaborator

CI likes it. Is it ready for review? (I agree that a readme addition is needed.)

@kubukoz
Copy link
Contributor Author

kubukoz commented Apr 28, 2025

Hi, sorry, it's been a busy couple weeks (as usual), I'll try to bring it up to reviewable this week.

@kubukoz
Copy link
Contributor Author

kubukoz commented Jun 18, 2025

I did it!!!!!!!!!!!

After this is released I'll add mima to https://github.com/coursier/apps and update the readme again to just say cs launch mima.

@kubukoz kubukoz marked this pull request as ready for review June 18, 2025 12:25
Copy link
Collaborator

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lrytz
Copy link
Collaborator

lrytz commented Jun 30, 2025

update the readme

maybe we could link to https://github.com/lightbend-labs/jardiff in the readme? it's certainly useful for me, not sure if it would be for library authors.

@lrytz lrytz merged commit 96dcaea into lightbend-labs:main Jun 30, 2025
11 checks passed
.crossType(CrossType.Pure)
.settings(
name := "mima-cli",
crossScalaVersions ++= Seq(scala3),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, was the intention here to set crossScalaVersions := Seq(scala3)? because with ++= we get

sbt:mima> show cliJVM/crossScalaVersions
[info] * 2.12.20
[info] * 3.3.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, oversight. I'll come back with a fix

@lrytz
Copy link
Collaborator

lrytz commented Jun 30, 2025

After this is released

This needs a bit of work (adjust to the switch to central portal), the release steps are not completely standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants