-
Notifications
You must be signed in to change notification settings - Fork 74
Add MiMa CLI #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MiMa CLI #823
Conversation
@SethTisue can we revive this? Hate to see this go to waste :) |
sure. let's see if CI likes it |
CI likes it. Is it ready for review? (I agree that a readme addition is needed.) |
Hi, sorry, it's been a busy couple weeks (as usual), I'll try to bring it up to reviewable this week. |
I did it!!!!!!!!!!! After this is released I'll add mima to https://github.com/coursier/apps and update the readme again to just say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
maybe we could link to https://github.com/lightbend-labs/jardiff in the readme? it's certainly useful for me, not sure if it would be for library authors. |
.crossType(CrossType.Pure) | ||
.settings( | ||
name := "mima-cli", | ||
crossScalaVersions ++= Seq(scala3), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, was the intention here to set crossScalaVersions := Seq(scala3)
? because with ++=
we get
sbt:mima> show cliJVM/crossScalaVersions
[info] * 2.12.20
[info] * 3.3.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, oversight. I'll come back with a fix
This needs a bit of work (adjust to the switch to central portal), the release steps are not completely standard. |
See #701.
Early state, probably should get at least a README. The code is pretty much a verbatim copy of https://github.com/jeremyrsmith/mima-cli/ (licensed under Apache 2.0, I'm not sure what the preferred protocol is for adding a notice here).