Skip to content

Conversation

ellemouton
Copy link
Collaborator

Depends on btcsuite/btclog#24
Fixes #10084
Replaces #10085

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ellemouton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the btclog/v2 dependency to incorporate a critical bug fix related to logger inheritance. The change ensures that child loggers correctly inherit log level changes from their parents, providing consistent logging behavior across the application. This update currently points to a temporary fork while the upstream fix is being finalized.

Highlights

  • Dependency Update: I've updated the btclog/v2 dependency by adding a replace directive in go.mod. This temporarily points to a specific commit (v2.0.0-20250723091135-8ba02441ee29) in the author's fork (github.com/ellemouton/btclog/v2) to incorporate a critical bug fix before it's officially released upstream.
  • Bug Fix: This PR addresses a bug where child loggers, when created using WithPrefix, did not correctly inherit log level changes from their parent loggers. The updated btclog/v2 version contains the fix to ensure proper log level propagation.
  • Documentation: I've added a new entry to the release-notes-0.20.0.md file, documenting the fix for the logger inheritance issue, ensuring it's captured in the upcoming release notes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the btclog/v2 version and includes a fix for a bug related to child logger inheritance. The changes involve modifications to go.mod, go.sum, and release notes. It's important to verify the compatibility and security implications of the btclog/v2 version bump, and also to ensure that the line length in the release notes does not exceed 80 characters.

@ellemouton ellemouton force-pushed the fixLogLevelInheritance branch from 2399f38 to 81d33b7 Compare July 29, 2025 05:20
@ellemouton ellemouton requested a review from Roasbeef July 29, 2025 05:21
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, otherwise LGTM 🎉
Thanks for the fix 🚀

@ellemouton ellemouton force-pushed the fixLogLevelInheritance branch from 81d33b7 to f129b21 Compare July 29, 2025 05:40
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪭

@Roasbeef Roasbeef merged commit 0eacd07 into lightningnetwork:master Jul 29, 2025
39 checks passed
@Roasbeef Roasbeef added this to the v0.19.3 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: lncli debuglevel --level info not working in v0.19.x
3 participants