Skip to content

Conversation

@ldjebran
Copy link
Contributor

@ldjebran ldjebran commented Dec 19, 2025

Tool Definition is using tool_name instead of name.
https://github.com/llamastack/llama-stack/blob/e710622d4c03c8a4549a93f70c993f22d0676910/src/llama_stack/models/llama/datatypes.py#L85

https://github.com/llamastack/llama-stack/blob/release-0.2.22/llama_stack/providers/inline/agents/meta_reference/agent_instance.py#L793

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Unit tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Copy link

@acosferreira acosferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Tool Definition is using tool_name instead of name.

Signed-off-by: Djebran Lezzoum <ldjebran@gmail.com>
@ldjebran
Copy link
Contributor Author

fixed unitest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants