TF-3894 Fix blank email content when opening email #3896
+321
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dab246 <tdvu@linagora.com>
dab246
force-pushed
the
bugfix/tf-3894-blank-email-content-when-opening-email
branch
from
0ce3802 to
68dc9e9
Compare
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3896. |
tddang-linagora
approved these changes
Jul 23, 2025
hoangdat
reviewed
Jul 23, 2025
| @@ -129,6 +129,26 @@ extension SessionExtension on Session { | |||
| return null; | |||
| } | |||
|
|
|||
| String generateOwnEmailAddressFromDomain(String domain) { | |||
There was a problem hiding this comment.
We create the exact email the user is using. Because identity has many different emails, only the domain is the same.
hoangdat
reviewed
Jul 23, 2025
Comment on lines
+29
to
+31
| final identityEmailAddress = listIdentities.firstOrNull?.email ?? ''; | ||
| final domain = EmailUtils.getDomainByEmailAddress(identityEmailAddress); | ||
| final userEmailAddress = |
There was a problem hiding this comment.
still not understand this point
There was a problem hiding this comment.
We create the exact email the user is using. Because identity has many different emails, only the domain is the same.
|
thank you |
|
gentle ping on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3894
Root cause
The
Stalwartserver does not return any email address in the session (#3717 (comment)) lead tosession.getOwnEmailAddress()throwing exception.tmail-flutter/lib/features/thread_detail/presentation/thread_detail_view.dart
Line 44 in be0ef81
Reproduce
reproduce.mov
Resolved
ownEmailAddress& identitywith-own-email-address.mov
ownEmailAddress& with identitywith-identities.mov
ownEmailAddress& identitywitout-identities.mov