Skip to content

Change order of attachment and mail body (master rebased) #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 31, 2025
Merged

Change order of attachment and mail body (master rebased) #3903

merged 7 commits into from
Jul 31, 2025

Conversation

tddang-linagora
Copy link
Collaborator

Ref

Mobile

attachment-mobile.webm

Web

Screen.Recording.2025-07-23.at.16.38.18.mov

@tddang-linagora tddang-linagora self-assigned this Jul 23, 2025
@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/3903.

@dab246 dab246 mentioned this pull request Jul 25, 2025
Closed
@tddang-linagora tddang-linagora force-pushed the bugfix/change-order-of-attachment-and-mail-body-master-rebased branch from f107dbb to eb2ff14 Compare July 25, 2025 03:02
@hoangdat
Copy link
Member

hoangdat commented Jul 25, 2025 •
edited by tddang-linagora
Loading

  • blue bar (calendar event) can not be render well
image

@hoangdat
Copy link
Member

hoangdat commented Jul 25, 2025 •
edited by tddang-linagora
Loading

  • drag attachment make attachment container disappear
Ghi.Man.hinh.2025-07-25.luc.15.32.23.mov

@chibenwa
Copy link
Member

How does this behave for a very long mail?

How does this behave in a thread?

I am sceptical about that change to be honnest...

@hoangdat
Copy link
Member

@chibenwa

  • beside the change of attachment panel to the bottom, we also add a toggle to collapse quoted content,
Ảnh màn hình 2025-07-25 lúc 17 42 28
  • but for the case of very long email, user still need to scroll to the end to see them

@tddang-linagora
Copy link
Collaborator Author

blue bar (calendar event) can not be render well

Screen.Recording.2025-07-28.at.14.48.26.mov

drag attachment make attachment container disappear

Screen.Recording.2025-07-28.at.14.48.10.mov

dab246
dab246 reviewed Jul 29, 2025
View reviewed changes
@dab246
Copy link
Member

dab246 commented Jul 29, 2025 •
edited by tddang-linagora
Loading

  • Attachment list view auto close when cancel export attachment. We should persist it.
Screen_recording_20250729_114556.webm

@tddang-linagora
Copy link
Collaborator Author

Attachment list view auto close when cancel export attachment. We should persist it.

Not reproducible

cancel.webm

@tddang-linagora tddang-linagora requested a review from dab246 July 29, 2025 09:03
@dab246
Copy link
Member

dab246 commented Jul 30, 2025

Attachment list view auto close when cancel export attachment. We should persist it.

Not reproducible

Only error occurs with toast message

ExportAttachmentFailure(HttpException: Connection closed while receiving data,
Screen.Recording.2025-07-30.at.10.52.08.mov

@tddang-linagora
Copy link
Collaborator Author

Attachment list view auto close when cancel export attachment. We should persist it.

Not reproducible

Only error occurs with toast message

ExportAttachmentFailure(HttpException: Connection closed while receiving data,

Fixed

toast.webm

dab246
dab246 previously approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please rebase it

@tddang-linagora tddang-linagora force-pushed the bugfix/change-order-of-attachment-and-mail-body-master-rebased branch from 60e71e3 to c3f7acb Compare July 31, 2025 07:01
dab246 and others added 6 commits July 31, 2025 14:53
@dab246 @tddang-linagora
Change order of attachment and mail body on mobile
42facbd 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246 @tddang-linagora
Change order of attachment and mail body on desktop
60082a6 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246 @tddang-linagora
Support vertical scrolling of all information between app bar and bot…
8766cc9 
…tom bar in email view

Signed-off-by: dab246 <tdvu@linagora.com>
@dab246 @tddang-linagora
Support vertical scrolling email view when cursor is over calendar ev…
bacba04 
…ent description

Signed-off-by: dab246 <tdvu@linagora.com>
@dab246 @tddang-linagora
Update toast message when start download all attachment
6427c0b 
Signed-off-by: dab246 <tdvu@linagora.com>
@tddang-linagora
Fix attachments cannot be export multiple times in mobile
82aae89
@tddang-linagora tddang-linagora force-pushed the bugfix/change-order-of-attachment-and-mail-body-master-rebased branch from c3f7acb to f8ce0f8 Compare July 31, 2025 07:53
@hoangdat hoangdat merged commit ef6008a into master Jul 31, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 left review comments

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tddang-linagora @hoangdat @chibenwa @dab246