fix: update systemd service dependencies for ApplicationManager1 #284
Conversation
Changed the symlink target in CMakeLists.txt from dde-session-initialized.target to dde-session-core.target. Updated the service file to reflect the new dependencies, replacing references to dde-session-initialized.target with dde-session-core.target. This ensures proper service management and initialization order. Log: as title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe pull request adjusts the systemd target dependency for ApplicationManager1 by changing references from dde-session-initialized.target to dde-session-core.target in both the CMake installation step and the service unit template, ensuring proper initialization order. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yixinshark - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review代码审查意见：
综上所述，建议在实施这些更改之前，进行充分的测试，确保它们不会对系统的其他部分产生负面影响。同时，应该更新相关的文档和注释，以便其他开发者能够理解这些更改的意图和影响。 |
|
TAG Bot New tag: 1.2.34 |
|
TAG Bot New tag: 1.2.35 |
|
TAG Bot New tag: 1.2.36 |
|
TAG Bot New tag: 1.2.38 |
There was a problem hiding this comment.
Pull request overview
This pull request updates the systemd service dependencies for ApplicationManager1 from dde-session-initialized.target to dde-session-core.target, reflecting a change in the session initialization architecture. The changes ensure that the ApplicationManager service integrates with the new session target structure.
Key Changes:
- Updated systemd service file to use
dde-session-core.targetinstead ofdde-session-initialized.target - Removed the
Requisitedependency directive while keepingPartOfandBeforedirectives - Updated CMakeLists.txt symlink installation to place the service in the correct target's wants directory
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| misc/systemd/user/org.desktopspec.ApplicationManager1.service.in | Updated service dependencies to reference dde-session-core.target; removed Requisite directive |
| misc/CMakeLists.txt | Updated symlink target from dde-session-initialized.target.wants to dde-session-core.target.wants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Requisite=dde-session-pre.target | ||
| After=dde-session-pre.target | ||
|
|
There was a problem hiding this comment.
The removal of the Requisite directive may cause issues with service startup dependencies. The original configuration had Requisite=dde-session-initialized.target, which ensured the service would fail immediately if the target was not active. The new configuration only has PartOf and Before directives for dde-session-core.target, but no Requisite directive.
If dde-session-core.target needs to be active before this service starts (similar to the previous requirement), consider adding Requisite=dde-session-core.target to maintain the strict dependency semantics. Otherwise, if this change is intentional and the service should be able to start regardless of whether dde-session-core.target is active, this should be documented in the commit message to clarify the behavior change.
| Requisite=dde-session-core.target |
|
TAG Bot New tag: 1.2.39 |
|
TAG Bot New tag: 1.2.40 |
|
TAG Bot New tag: 1.2.41 |
2 participants
Changed the symlink target in CMakeLists.txt from dde-session-initialized.target to dde-session-core.target. Updated the service file to reflect the new dependencies, replacing references to dde-session-initialized.target with dde-session-core.target. This ensures proper service management and initialization order.
Log: as title
Summary by Sourcery
Update systemd service dependencies for ApplicationManager1 to depend on dde-session-core.target instead of dde-session-initialized.target.
Bug Fixes:
Build: