Skip to content

Conversation

@18202781743
Copy link
Contributor

  1. Changed the installation destination for dtkcore_config.h from
    "${INCLUDE_INSTALL_DIR}/DCore/global/" to "${INCLUDE_INSTALL_DIR}"
  2. The header file was being installed in an incorrect subdirectory
    structure
  3. This ensures dtkcore_config.h is placed in the correct include
    directory for proper compilation

Influence:

  1. Verify dtkcore_config.h is now installed in the correct include
    directory
  2. Test compilation of projects that depend on dtkcore headers
  3. Check that all include paths work correctly after installation
  4. Ensure backward compatibility with existing code that includes
    dtkcore_config.h

fix: 修正 dtkcore_config.h 安装路径

  1. 将 dtkcore_config.h 的安装目标从 "${INCLUDE_INSTALL_DIR}/DCore/
    global/" 更改为 "${INCLUDE_INSTALL_DIR}"
  2. 头文件之前被安装在不正确的子目录结构中
  3. 这确保 dtkcore_config.h 被放置在正确的包含目录中以进行正确编译

Influence:

  1. 验证 dtkcore_config.h 现在是否安装在正确的包含目录中
  2. 测试依赖 dtkcore 头文件的项目的编译
  3. 检查安装后所有包含路径是否正确工作
  4. 确保与现有包含 dtkcore_config.h 的代码向后兼容

1. Changed the installation destination for dtkcore_config.h from
"${INCLUDE_INSTALL_DIR}/DCore/global/" to "${INCLUDE_INSTALL_DIR}"
2. The header file was being installed in an incorrect subdirectory
structure
3. This ensures dtkcore_config.h is placed in the correct include
directory for proper compilation

Influence:
1. Verify dtkcore_config.h is now installed in the correct include
directory
2. Test compilation of projects that depend on dtkcore headers
3. Check that all include paths work correctly after installation
4. Ensure backward compatibility with existing code that includes
dtkcore_config.h

fix: 修正 dtkcore_config.h 安装路径

1. 将 dtkcore_config.h 的安装目标从 "${INCLUDE_INSTALL_DIR}/DCore/
global/" 更改为 "${INCLUDE_INSTALL_DIR}"
2. 头文件之前被安装在不正确的子目录结构中
3. 这确保 dtkcore_config.h 被放置在正确的包含目录中以进行正确编译

Influence:
1. 验证 dtkcore_config.h 现在是否安装在正确的包含目录中
2. 测试依赖 dtkcore 头文件的项目的编译
3. 检查安装后所有包含路径是否正确工作
4. 确保与现有包含 dtkcore_config.h 的代码向后兼容
@18202781743 18202781743 requested review from BLumia and mhduiy December 11, 2025 11:44
deepin-ci-robot added a commit to linuxdeepin/dtk6core that referenced this pull request Dec 11, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#524
@18202781743 18202781743 requested a review from asterwyx December 11, 2025 11:44
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

我来分析一下这个git diff的修改内容:

  1. 修改内容分析:
    这个修改改变了安装目标文件的路径,从原来的${INCLUDE_INSTALL_DIR}/DCore/global/改为了${INCLUDE_INSTALL_DIR}

  2. 改进建议:

  • 安装路径变更的影响:

    • 这个修改将配置文件直接安装到了include目录下,而不是之前的DCore/global子目录
    • 这样的变更可能会破坏现有的目录结构,建议谨慎评估
    • 如果确实需要修改安装路径,建议保持一定的目录结构,比如改为${INCLUDE_INSTALL_DIR}/dtk/或类似的子目录
  • 建议改进:

# 更规范的安装路径
install(FILES ${CONFIGNAME} DESTINATION "${INCLUDE_INSTALL_DIR}/dtk")
  1. 潜在问题:
  • 直接安装到include根目录可能会导致文件冲突
  • 破坏了原有的目录组织结构
  • 可能影响其他依赖此库的项目
  1. 建议:
  • 在进行此类修改前,建议先评估现有项目的依赖情况
  • 如果确实需要修改安装路径,建议发布版本更新说明
  • 考虑添加向后兼容性支持,比如同时支持新旧路径
  1. 其他建议:
  • 可以考虑在安装时创建必要的目录结构
  • 建议在CMake文档中明确说明安装路径的变更

总的来说,这个修改虽然简单,但可能会对依赖此库的项目产生较大影响,建议谨慎处理。如果必须修改,建议采用更规范的目录结构,并做好版本兼容性处理。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 390c199 into linuxdeepin:master Dec 11, 2025
18 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6core that referenced this pull request Dec 11, 2025
Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants