Cvc null check profile #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've tested this all day yesterday and today on my computers that run LM and I haven't ran into any issues so far! |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a potential crash scenario by adding NULL checks for the return value of gvc_mixer_card_get_profile() in two functions, preventing subsequent dereference and fallback crashes.
- Adds a NULL check in gvc_mixer_ui_device_get_active_profile() to log a warning and return NULL.
- Adds a NULL check in gvc_mixer_control_change_profile_on_selected_device() to log a warning and return FALSE.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libcvc/gvc-mixer-ui-device.c | Added a NULL check to ensure safe handling when gvc_mixer_card_get_profile() returns NULL. |
| libcvc/gvc-mixer-control.c | Added a NULL check to handle cases where gvc_mixer_card_get_profile() returns NULL and avoid crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #253 by adding NULL checks for
gvc_mixer_card_get_profile()in two locations:gvc_mixer_ui_device_get_matching_profile()(ingvc-mixer-ui-device.c)gvc_mixer_control_change_output()(ingvc-mixer-control.c)Previously, if
gvc_mixer_card_get_profile()returned NULL (e.g., during initial Bluetooth connection), it could cause Cinnamon to crash into fallback mode. These checks prevent that by logging a warning and safely returning a value that can be handled (NULL&FALSE)Tested locally with Sony WH-1000XM4 headphones on Linux Mint 21.3.