yfquotes@thegli: refactoring, decomposition #1671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @thegli |
Contributor
Author
|
@thegli Hi Thomas, could you please review my PR? |
Contributor
Author
|
@thegli 🥺 |
sulonetskyy
force-pushed
the
yfq-refactoring
branch
from
a6223ce to
ab54bb5
Compare
- extract utilities to separate module - extract constants to separate module - extract logging functionality to separate module - extract quote reading functionality to separate module - extract soup resolver functionality to separate module
sulonetskyy
force-pushed
the
yfq-refactoring
branch
from
ab54bb5 to
dedd2aa
Compare
sulonetskyy
changed the title
sulonetskyy
changed the title
Contributor
Author
|
@thegli please review and approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.