Skip to content

Conversation

@mlandsjr
Copy link

Added my Cinamp Desklet.

@fredcw
Copy link
Contributor

fredcw commented Nov 22, 2025

desklet doesn't load for some reason, I don't know why, nothing in ~/.xsession-errors. Also, directory structure is wrong: https://github.com/linuxmint/cinnamon-spices-desklets?tab=readme-ov-file#file-structure

@mlandsjr
Copy link
Author

I'll double check the structure part.

@claudiux claudiux marked this pull request as draft November 22, 2025 14:13
@claudiux claudiux marked this pull request as ready for review November 22, 2025 20:00
@claudiux
Copy link
Member

@mlandsjr Please fix the issues.

@claudiux claudiux marked this pull request as draft November 22, 2025 20:17
@claudiux
Copy link
Member

@mlandsjr
[cinamp@mlandsjr] Error during validation: [cinamp@mlandsjr] icon.png has to be square.

@claudiux
Copy link
Member

Resize icon.png to 128x128 max.

@claudiux claudiux changed the title Add files via upload Cinamp: New Desklet Nov 22, 2025
@mlandsjr
Copy link
Author

fixed icon size

@mlandsjr mlandsjr marked this pull request as ready for review November 23, 2025 00:50
@claudiux claudiux marked this pull request as draft November 23, 2025 12:00
@claudiux
Copy link
Member

Found several errors. I'll try to fix them.

change DEFAULT_DIR line 14
@claudiux
Copy link
Member

@mlandsjr
Please take my changes into account in your code.
Then add a button to scan the music directory. Do not start the scan at startup, as this freezes Cinnamon for a long time.

Line 894: this.discoverer.discover_uri_async(uri, isNewTrack);
The discover_uri_async() takes only one argument, which is uri.
The isNewTrack argument causes an error. Please fix that.

@claudiux
Copy link
Member

Volume bar and Progress bar do not display nothing.
Icon is not squared.
image

`width: 100%;`: percentage lengths not currently supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants