-
Notifications
You must be signed in to change notification settings - Fork 206
Cinnaclock: New layered clock desklet #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Nice desklet, it works well. The directory structure is slightly wrong, see https://github.com/linuxmint/cinnamon-spices-desklets?tab=readme-ov-file#file-structure. And you need an Also, I don't know if it's required but it might help the team to understand your code easier if your code comments were in English. https://linuxmint-developer-guide.readthedocs.io/en/latest/requirements.html#speaking-english |
|
Also, I have a suggestion for maybe a later version, but it's entirely up to you of course. If there was some "presets" to choose from with a few nice designs (like in your screenshot) then that may be easier for users who don't have time to do it themselves or don't have the design flair. |
|
Thanks so much for the feedback fredcw! I'll fix the directory structure and the info file. I forgot to remove the code comments: most of them aren't necessary; the ones I leave will be in English.
I really like the suggestion of creating presets like in the "Seven Segment Clock" desklet. I'll study your code in the next few days to achieve a similar result. This is my first project for Cinnamon, so I'm happy to receive any further suggestions or corrections. |
Translation code comments in English
…@dingo/files/cinnaclock@dingo/metadata.json
Added guidance on fonts and preset customization
Translated the annotations into English and added code for using presets
Added code for presets
New translations based on the latest version of the desklet
New screenshot with preset images
|
All revision requests have been processed. The desklet now offers both the option to choose a default clock and to customize it to your liking. All files have been updated. |
|
Your applet shouldn't be nested inside the "desklets" folder in this PR. Apart from that, the file structure is good. The validation tool doesn't like the "icon" field in metadata.json. "author" field is not needed in metadata.json as it's already in info.json. You should probably add |
…rectory Delete redundant folders
Hello, I would like to submit a new desklet called Cinnaclock.
It is a modern and highly customizable clock that displays time, day, and date on separate layers.
Key features:
I have included the required
metadata.json,icon.png, andscreenshot.pngfiles.