remove notification webhook and send of email #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
reviewed
Jan 27, 2025
Member
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
Looks good but make sure to cleanup the env/readme that probably contains these env/features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves the removal of several email notification templates and their related dependencies. The changes include deleting the email templates for various events, removing the corresponding imports and configurations, and updating the
package.jsonfile to remove unused dependencies.Removal of email notification templates:
emails/AccountCreatedReferral.ts: Removed the email template for account creation referrals.emails/BidAccepted.ts: Removed the email template for bid acceptance notifications.emails/BidCreated.ts: Removed the email template for new bid notifications.emails/BidExpired.ts: Removed the email template for bid expiration notifications.emails/OfferExpired.ts: Removed the email template for offer expiration notifications.emails/OfferPurchased.ts: Removed the email template for offer purchase notifications.Updates to
package.json:@nft/webhookdependency.nodemailerdependency.@types/nodemailerdependency.Changes to API:
pages/api/notification.ts: Removed the entire notification handling logic, including imports of email templates, configuration of the nodemailer transporter, and the map of email templates for different events.Checklist
dev