Teach http_client to send "priority"; improve logs #587
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make it easier to play with priorities and demonstrate the way lsquic implements RFC 9218.
There was a problem hiding this comment.
Pull request overview
This PR enhances the http_client tool to support sending the "priority: i" header for testing HTTP/3 extensible priorities (RFC 9218) and improves debugging output in the HTTP priority iterator.
- Adds a new
-Ncommand-line flag to send "priority: i" header (incremental priority) - Improves logging in lsquic_hpi.c by adding priority and incremental info to debug output
- Moves debug log from loop to the function that adds streams to show more context
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/liblsquic/lsquic_hpi.c | Enhanced debug logging to include incremental flag and priority value; removed less informative log statement |
| bin/http_client.c | Added -N flag and s_priority_incremental variable to send "priority: i" header; updated usage documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it easier to play with priorities and demonstrate the way lsquic implements RFC 9218.