[CIR][ThroughMLIR] Lower simple SwitchOp #1742
Open
+286
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| : public mlir::PassWrapper<MLIRLoweringPrepare, | ||
| mlir::OperationPass<mlir::ModuleOp>> { | ||
| // `scf.index_switch` requires that switch branches do not fall through. | ||
| // We need to copy the next branch's body when the current `cir.case` does not |
There was a problem hiding this comment.
Seems like this violates 80-col?
There was a problem hiding this comment.
Seems clang-format didn't report that. I changed it manually.
lanza
force-pushed
the
main
branch
2 times, most recently
from
d2c4ab8 to
8f89224
Compare
|
Rebase conflicts are now resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with fall-through by copying the body of the next
cir.caseto the previous case. This is needed becausescf.index_switchdoes not support falling through.