[CIR] Add syncscope support for atomic load operations #1958
+151
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiang1997
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
jiang1997
force-pushed
the
fix-#1868
branch
2 times, most recently
from
5b25f33 to
af464b6
Compare
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Thanks for working on this. Almost good, some issues need addressing!
xlauko
reviewed
Nov 4, 2025
xlauko
reviewed
Nov 4, 2025
xlauko
reviewed
Nov 4, 2025
jiang1997
force-pushed
the
fix-#1868
branch
2 times, most recently
from
6e83ac5 to
7e9639a
Compare
bcardosolopes
approved these changes
Nov 6, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Few minor nits remaining
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Member
|
Seems like there's also some bad formatting needing fixes |
jiang1997
force-pushed
the
fix-#1868
branch
2 times, most recently
from
7619441 to
9461972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1868