[libc++] Fix incorrect install component for the libc++ linker script #171663
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the name of the install component for the libc++ linker script. Every other target mentions the cxx component, and that one mentions libcxx. I believe that was a typo in 4bd3d16.
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThis patch fixes the name of the install component for the libc++ linker script. Every other target mentions the cxx component, and that one mentions libcxx. I believe that was a typo in 4bd3d16. Full diff: https://github.com/llvm/llvm-project/pull/171663.diff 1 Files Affected:
diff --git a/libcxx/src/CMakeLists.txt b/libcxx/src/CMakeLists.txt
index f59fe0e08fccb..0063c26161313 100644
--- a/libcxx/src/CMakeLists.txt
+++ b/libcxx/src/CMakeLists.txt
@@ -381,7 +381,7 @@ endif()
if (LIBCXX_ENABLE_SHARED AND LIBCXX_ENABLE_ABI_LINKER_SCRIPT)
install(FILES "$<TARGET_LINKER_FILE:cxx_shared>"
DESTINATION ${LIBCXX_INSTALL_LIBRARY_DIR}
- COMPONENT libcxx)
+ COMPONENT cxx)
endif()
if (NOT CMAKE_CONFIGURATION_TYPES)
|
arichardson
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the name of the install component for the libc++ linker script. Every other target mentions the cxx component, and that one mentions libcxx. I believe that was a typo in 4bd3d16.