[libcxx] Remove TODO related to LWG4275 #171665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LWG4275 has been moved to a working paper, so we can remove this TODO now. Related to llvm#171329
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Aiden Grossman (boomanaiden154) ChangesLWG4275 has been moved to a working paper, so we can remove this TODO now. Related to #171329 Full diff: https://github.com/llvm/llvm-project/pull/171665.diff 1 Files Affected:
diff --git a/libcxx/include/mdspan b/libcxx/include/mdspan
index 5aeec1bcbfc39..32468a128dc9a 100644
--- a/libcxx/include/mdspan
+++ b/libcxx/include/mdspan
@@ -450,11 +450,7 @@ namespace std {
# include <__config>
# if _LIBCPP_STD_VER >= 23
-# include <__fwd/mdspan.h> // TODO(boomanaiden154): This is currently a
- // non-standard extension to include
- // std::dynamic_extent tracked by LWG issue 4275.
- // This comment should be deleted or the include
- // deleted upon resolution.
+# include <__fwd/mdspan.h>
# include <__fwd/span.h>
# include <__mdspan/default_accessor.h>
# include <__mdspan/extents.h>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LWG4275 has been moved to a working paper, so we can remove this TODO now.
Related to #171329