Skip to content

Conversation

@ldionne
Copy link
Member

@ldionne ldionne commented Dec 10, 2025

Otherwise, the lines are extremely long and basically impossible to read.

Otherwise, the lines are extremely long and basically impossible
to read.
@ldionne ldionne requested a review from a team as a code owner December 10, 2025 20:11
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Dec 10, 2025
@llvmbot
Copy link
Member

llvmbot commented Dec 10, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Otherwise, the lines are extremely long and basically impossible to read.


Full diff: https://github.com/llvm/llvm-project/pull/171688.diff

2 Files Affected:

  • (modified) libcxx/test/libcxx/clang_tidy.gen.py (+5-1)
  • (modified) libcxx/test/libcxx/clang_tidy.sh.py (+5-1)
diff --git a/libcxx/test/libcxx/clang_tidy.gen.py b/libcxx/test/libcxx/clang_tidy.gen.py
index 16c90c3ef7130..614df2e5992f0 100644
--- a/libcxx/test/libcxx/clang_tidy.gen.py
+++ b/libcxx/test/libcxx/clang_tidy.gen.py
@@ -27,7 +27,11 @@
 {lit_header_undeprecations.get(header, '')}
 
 // TODO: run clang-tidy with modules enabled once they are supported
-// RUN: %{{clang-tidy}} %s --warnings-as-errors=* -header-filter=.* --config-file=%{{libcxx-dir}}/.clang-tidy --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin -- -Wweak-vtables %{{compile_flags}} -fno-modules
+// RUN: %{{clang-tidy}} %s --warnings-as-errors=*                                           \\
+// RUN:                    -header-filter=.*                                                \\
+// RUN:                    --config-file=%{{libcxx-dir}}/.clang-tidy                        \\
+// RUN:                    --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin  \\
+// RUN:                    -- -Wweak-vtables %{{compile_flags}} -fno-modules
 
 #include <{header}>
 """)
diff --git a/libcxx/test/libcxx/clang_tidy.sh.py b/libcxx/test/libcxx/clang_tidy.sh.py
index 46f281f359209..630428564597d 100644
--- a/libcxx/test/libcxx/clang_tidy.sh.py
+++ b/libcxx/test/libcxx/clang_tidy.sh.py
@@ -8,4 +8,8 @@
 
 # REQUIRES: has-clang-tidy
 
-# RUN: %{python} %{libcxx-dir}/../clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -clang-tidy-binary %{clang-tidy} -warnings-as-errors "*" -source-filter=".*libcxx/src.*" -quiet -p %{bin-dir}/..
+# RUN: %{python} %{libcxx-dir}/../clang-tools-extra/clang-tidy/tool/run-clang-tidy.py   \
+# RUN:      -clang-tidy-binary %{clang-tidy}                                            \
+# RUN:      -warnings-as-errors "*"                                                     \
+# RUN:      -source-filter=".*libcxx/src.*"                                             \
+# RUN:      -quiet -p %{bin-dir}/..

@github-actions
Copy link

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r origin/main...HEAD libcxx/test/libcxx/clang_tidy.gen.py libcxx/test/libcxx/clang_tidy.sh.py

⚠️
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing origin/main to the base branch/commit you want to compare against.
⚠️

View the diff from darker here.
--- clang_tidy.gen.py	2025-12-10 20:35:16.000000 +0000
+++ clang_tidy.gen.py	2025-12-10 21:14:28.671172 +0000
@@ -32,6 +32,7 @@
 // RUN:                    --config-file=%{{libcxx-dir}}/.clang-tidy                        \\
 // RUN:                    --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin  \\
 // RUN:                    -- -Wweak-vtables %{{compile_flags}} -fno-modules
 
 #include <{header}>
-""")
+"""
+    )

@ldionne ldionne merged commit 54b62d7 into llvm:main Dec 11, 2025
73 of 80 checks passed
@ldionne ldionne deleted the review/nfc-indent-clang-tidy branch December 11, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants