Skip to content

[libc++] Add missing %{flags} substitution to clang-tidy #171689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldionne wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −8
Open

[libc++] Add missing %{flags} substitution to clang-tidy #171689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4be1d3c
[libc++] Add missing %{flags} substitution to clang-tidy
ldionne Dec 10, 2025
3315685
Add missing NODEBUG
ldionne Dec 11, 2025
ec2ee12
Merge branch 'main' into review/add-flags-to-clang-tidy
ldionne Dec 11, 2025
e9bf97a
Avoid ADL
ldionne Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libcxx/include/__cxx03/deque
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ public:
// This function tests deque object annotations.
if (empty()) {
for (__map_const_iterator __it = __map_.begin(); __it != __map_.end(); ++__it) {
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
std::__to_address(*__it),
std::__to_address(*__it),
Expand Down Expand Up @@ -950,7 +950,7 @@ public:

// Is the block before or after deque blocks that contain elements?
if (__it < __first_mp || __it > __last_mp) {
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
std::__to_address(*__it),
std::__to_address(*__it),
Expand All @@ -960,7 +960,7 @@ public:
const void* __containers_buffer_beg = (__it == __first_mp) ? __p_beg : (const void*)std::__to_address(*__it);
const void* __containers_buffer_end =
(__it == __last_mp) ? __p_end : (const void*)std::__to_address(*__it + __block_size);
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
__containers_buffer_beg,
__containers_buffer_end,
Expand Down
6 changes: 3 additions & 3 deletions libcxx/include/deque
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ public:
// This function tests deque object annotations.
if (empty()) {
for (__map_const_iterator __it = __map_.begin(); __it != __map_.end(); ++__it) {
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
std::__to_address(*__it),
std::__to_address(*__it),
Expand Down Expand Up @@ -1151,7 +1151,7 @@ public:

// Is the block before or after deque blocks that contain elements?
if (__it < __first_mp || __it > __last_mp) {
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
std::__to_address(*__it),
std::__to_address(*__it),
Expand All @@ -1161,7 +1161,7 @@ public:
const void* __containers_buffer_beg = (__it == __first_mp) ? __p_beg : (const void*)std::__to_address(*__it);
const void* __containers_buffer_end =
(__it == __last_mp) ? __p_end : (const void*)std::__to_address(*__it + __block_size);
if (!__sanitizer_verify_double_ended_contiguous_container(
if (!::__sanitizer_verify_double_ended_contiguous_container(
std::__to_address(*__it),
__containers_buffer_beg,
__containers_buffer_end,
Expand Down
2 changes: 1 addition & 1 deletion libcxx/include/string
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ public:
// external memory. In such cases, the destructor is responsible for unpoisoning
// the memory to avoid triggering false positives.
// Therefore it's crucial to ensure the destructor is called.
using __trivially_relocatable = void;
using __trivially_relocatable _LIBCPP_NODEBUG = void;
# else
using __trivially_relocatable _LIBCPP_NODEBUG = __conditional_t<
__libcpp_is_trivially_relocatable<allocator_type>::value && __libcpp_is_trivially_relocatable<pointer>::value,
Expand Down
2 changes: 1 addition & 1 deletion libcxx/test/libcxx/clang_tidy.gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
// RUN: -header-filter=.* \\
// RUN: --config-file=%{{libcxx-dir}}/.clang-tidy \\
// RUN: --load=%{{test-tools-dir}}/clang_tidy_checks/libcxx-tidy.plugin \\
// RUN: -- -Wweak-vtables %{{compile_flags}} -fno-modules
// RUN: -- -Wweak-vtables %{{flags}} %{{compile_flags}} -fno-modules

#include <{header}>
""")
Loading