Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Dec 11, 2025

Backport 3fdce79

Requested by: @brad0

Co-authored-by: Jérôme Duval <jerome.duval@gmail.com>
(cherry picked from commit 3fdce79)
@llvmbot llvmbot requested a review from a team as a code owner December 11, 2025 02:35
@llvmbot llvmbot added this to the LLVM 21.x Release milestone Dec 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Dec 11, 2025
@llvmbot
Copy link
Member Author

llvmbot commented Dec 11, 2025

@mstorsjo What do you think about merging this PR to the release branch?

@llvmbot
Copy link
Member Author

llvmbot commented Dec 11, 2025

@llvm/pr-subscribers-libunwind

Author: None (llvmbot)

Changes

Backport 3fdce79

Requested by: @brad0


Full diff: https://github.com/llvm/llvm-project/pull/171754.diff

1 Files Affected:

  • (modified) libunwind/src/UnwindCursor.hpp (+3-2)
diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp
index 9a1afd3721f5a..1dcf2e14da851 100644
--- a/libunwind/src/UnwindCursor.hpp
+++ b/libunwind/src/UnwindCursor.hpp
@@ -41,7 +41,8 @@
 #define _LIBUNWIND_CHECK_LINUX_SIGRETURN 1
 #endif
 
-#if defined(_LIBUNWIND_TARGET_HAIKU) && defined(_LIBUNWIND_TARGET_X86_64)
+#if defined(_LIBUNWIND_TARGET_HAIKU) &&                                        \
+    (defined(_LIBUNWIND_TARGET_I386) || defined(_LIBUNWIND_TARGET_X86_64))
 #include <OS.h>
 #include <signal.h>
 #define _LIBUNWIND_CHECK_HAIKU_SIGRETURN 1
@@ -1345,7 +1346,7 @@ class UnwindCursor : public AbstractUnwindCursor{
   bool             _unwindInfoMissing;
   bool             _isSignalFrame;
 #if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) ||                               \
-    defined(_LIBUNWIND_TARGET_HAIKU)
+    defined(_LIBUNWIND_CHECK_HAIKU_SIGRETURN)
   bool             _isSigReturn = false;
 #endif
 };

@dyung dyung moved this from Needs Triage to Needs Review in LLVM Release Status Dec 12, 2025
@dyung
Copy link
Collaborator

dyung commented Dec 12, 2025

If you would like this fix included in the 21.x release branch, can you take a look at the premerge test failures to verify they are not related to the change and get someone to approve the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants