Skip to content

[TOSA] Handle float<->bool cast via i8 in tosaCastTensorToType #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
+83 −0
Merged

[TOSA] Handle float<->bool cast via i8 in tosaCastTensorToType #4257

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1649e9a
[TOSA] Handle float<->bool cast via i8 in tosaCastTensorToType
Lallapallooza Jul 7, 2025
941521b
Merge branch 'llvm:main' into tosa_progressive_cast
Lallapallooza Jul 17, 2025
b80a57c
fix the float<->i1 flow and add tests
Lallapallooza Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/Conversion/TorchToTosa/TosaLegalizeUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,16 @@ std::optional<Value> tosaCastTensorToType(PatternRewriter &rewriter, Value src,
// if (failed(checkValidityOfCast(srcElemTy, destElemTy)))
// return std::nullopt;

// Check if the source and destination types are boolean or floating-point
if ((srcElemTy.isInteger(1) && llvm::isa<FloatType>(destElemTy)) ||
(llvm::isa<FloatType>(srcElemTy) && destElemTy.isInteger(1))) {
// TOSA does not support casting between float<->i8.
// Instead, we cast to i8 and then to the destination type.
TensorType midType = srcType.clone(rewriter.getIntegerType(8));
Value mid = rewriter.create<tosa::CastOp>(op->getLoc(), midType, src);
return tosaCastTensorToType(rewriter, mid, destType); // recurse once
}

if (srcElemTy == destElemTy)
return src;

Expand Down