[TorchToLinalg] Support lowering AtenMaxUnpool2dOp for linalg backend #4265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vivekkhandelwal1 , @zjgarvey , @sahas3 can you please provide a review ? |
sahas3
requested review from
zjgarvey,
vivekkhandelwal1 and
sahas3
and removed request for
zjgarvey
|
@vivekkhandelwal1 , @zjgarvey , @sahas3 can you please review the PR ? |
sahas3
reviewed
Jul 21, 2025
projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/abstract_interp_lib_gen.py
Show resolved
Hide resolved
projects/pt1/python/torch_mlir/jit_ir_importer/build_tools/abstract_interp_lib_gen.py
Show resolved
Hide resolved
|
@vivekkhandelwal1 , @zjgarvey can you please review ? |
zjgarvey
approved these changes
Aug 6, 2025
zjgarvey
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds support to lower AtenMaxUnpool2dOp for linalg backend. Existing lowering for AtenMaxUnpool3dOp is refactored such that 2d/3d variants share utils
Unlike max_unpool3d, max_unpool2d does not support specification of stride, padding
torch op registry
The default values of stride and padding
https://docs.pytorch.org/docs/stable/generated/torch.nn.MaxUnpool2d.html
Closes #4255