Skip to content

[Root Signatures] Fix default values for Descriptor Range Flags and Root Descriptor Flags in Version 1 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

[Root Signatures] Fix default values for Descriptor Range Flags and Root Descriptor Flags in Version 1 #297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf6cd5
Update 0002-root-signature-in-clang.md
joaosaffran Jun 18, 2025
8efc95f
Address Comments
joaosaffran Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions proposals/0002-root-signature-in-clang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,10 @@ As specified in the grammar, '0' denotes there are no flags set.
- `RootFlags = 0`
- `ROOT_DESCRIPTOR_FLAGS` and `DESCRIPTOR_RANGE_FLAGS`
- Version 1.0:
- `DATA_VOLATILE`
- `CBV`: `DATA_VOLATILE | DESCRIPTORS_VOLATILE`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also be split into the different flag types. DESCRIPTORS_VOLATILE isn't a valid ROOT_DESCRIPTOR_FLAG

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaosaffran This does not appear to have been handled before merging.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will address it in a future PR

- `SRV`: `DATA_VOLATILE | DESCRIPTORS_VOLATILE`
- `UAV`: `DATA_VOLATILE | DESCRIPTORS_VOLATILE`
- `Sampler`: `DESCRIPTORS_VOLATILE`
- Version 1.1:
- `CBV`: `DATA_STATIC_WHILE_SET_AT_EXECUTE`
- `SRV`: `DATA_STATIC_WHILE_SET_AT_EXECUTE`
Expand Down Expand Up @@ -561,6 +564,14 @@ Most values like ShaderVisibility/ParameterType are covered by syntactical
checks in Sema.
The additional semantic rules not already covered by the grammar are listed here.

- For ROOT_DESCRIPTOR_FLAGS, only the following values are valid
- For version 1.0, only the value DATA_VOLATILE is valid.
- For version 1.1, the following values are valid:
- 0
- DATA_STATIC
- DATA_STATIC_WHILE_SET_AT_EXECUTE
- DATA_VOLATILE

- For DESCRIPTOR_RANGE_FLAGS on a Sampler, only the following values are valid
- For version 1.0, only the value DESCRIPTORS_VOLATILE is valid.
- For version 1.1, the following values are valid:
Expand All @@ -569,7 +580,7 @@ The additional semantic rules not already covered by the grammar are listed here
- DESCRIPTORS_STATIC_KEEPING_BUFFER_BOUNDS_CHECKS

- For DESCRIPTOR_RANGE_FLAGS on a CBV/SRV/UAV
- For version 1.0, only the value DATA_VOLATILE is valid.
- For version 1.0, only the value DATA_VOLATILE | DESCRIPTORS_VOLATILE is valid.
- For version 1.1, the following values are valid:
- 0
- DESCRIPTORS_VOLATILE
Expand Down Expand Up @@ -803,7 +814,7 @@ Operands:
- DataStatic

- Valid values for DescriptorRangeFlags on CBV/SRV/UAV
- For root signature version 1.0 must be DESCRIPTORS_VOLATILE.
- For root signature version 1.0 must be DATA_VOLATILE | DESCRIPTORS_VOLATILE.
- For root signature version 1.1:
- 0
- DESCRIPTORS_VOLATILE
Expand All @@ -818,7 +829,7 @@ Operands:
- DESCRIPTORS_STATIC_KEEPING_BUFFER_BOUNDS_CHECKS | DATA_STATIC_WHILE_SET_AT_EXECUTE

- Valid values for DescriptorRangeFlags on Sampler
- For root signature version 1.0 must be 0.
- For root signature version 1.0 must be DESCRIPTORS_VOLATILE.
- For root signature version 1.1:
- 0
- DESCRIPTORS_VOLATILE
Expand Down