Skip to content

[NNNN] Proposal: Add Root Signature related driver options #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

inbelic
Copy link
Collaborator

@inbelic inbelic commented Jul 16, 2025

DXC provided a number of command line options for working with root signatures. Namely: Frs, Qstrip_rootsignature, setrootsignature, extractrootsignature, verifyrootsignature, force-rootsig-ver and rootsig-define.

This pr proposes a how the functionality of these options will be implemented into clang and documents the expected behaviour that they should provide.

This pr documents the expected behaviours of different root signature
related command line options that exist in DXC and will implemented in
Clang
Copy link
Collaborator

@bogner bogner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to move this proposal into its own numbered file. Proposal 0002 is already very large, and this is largely orthogonal. A few questions and comments inline.

inbelic and others added 2 commits July 16, 2025 23:17
@inbelic inbelic marked this pull request as ready for review July 18, 2025 18:29
@inbelic inbelic changed the title [0002] Proposal: Add Root Signature related driver options [NNNN] Proposal: Add Root Signature related driver options Jul 18, 2025
Comment on lines +117 to +118
_Note_: Behaviour differs from DXC as it will perform resource binding
validations since this information is available.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Note_: Behaviour differs from DXC as it will perform resource binding
validations since this information is available.
_Note_: Behaviour differs from DXC as it will perform resource binding
validations when this information is available.

- Requires the provided DXIL Container to be a valid DXIL container with an
RST0 part

## Acknowledgments (Optional)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just drop this section if you're not putting anything in it

@bogner
Copy link
Collaborator

bogner commented Jul 22, 2025

Remember to give this a number before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0002] Root Signatures - Specifying command line support for root signatures
3 participants