Skip to content

fix: test finish comment fix #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: test finish comment fix #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1c752
fix: test finish comment fix
lakkeger Jun 12, 2024
5a0337b
fix: try shutdown
lakkeger Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
uses: actions/checkout@v4

- name: Deploy Preview
uses: LocalStack/setup-localstack@v0.2.0
uses: LocalStack/setup-localstack@fix_finish_comment
env:
LOCALSTACK_API_KEY: ${{ secrets.LOCALSTACK_API_KEY }}
with:
Expand All @@ -23,24 +23,18 @@ jobs:
state-action: start
include-preview: 'true'
install-awslocal: 'true'
skip-ephemeral-stop: 'false'
# Multi line commands are folding for some reason, so we enforce new lines
# For more predictable usage, use script files
preview-cmd: |
npm install -g aws-cdk-local aws-cdk;
make build;
make bootstrap;
make deploy;
make prepare-frontend-local;
make build-frontend;
make bootstrap-frontend;
make deploy-frontend;
distributionId=$(awslocal cloudfront list-distributions | jq -r '.DistributionList.Items[0].Id');
echo \"PREVIEW_URL=$AWS_ENDPOINT_URL/cloudfront/$distributionId/\" >> $GITHUB_ENV;
npm install -g aws-cdk-local aws-cdk
make build
make bootstrap
make deploy
make prepare-frontend-local
make build-frontend
make bootstrap-frontend
make deploy-frontend
distributionId=$(awslocal cloudfront list-distributions | jq -r '.DistributionList.Items[0].Id')
echo "PREVIEW_URL=$AWS_ENDPOINT_URL/cloudfront/$distributionId/" >> $GITHUB_ENV


- name: Finalize PR comment
uses: LocalStack/setup-localstack/finish@v0.2.0
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
include-preview: true
preview-url: ${{ env.PREVIEW_URL }}