-
Notifications
You must be signed in to change notification settings - Fork 506
Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
29a925a
to
f9ab0af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test this as well here?
Also, with changing the virtual object's spec and status after its assigned from the host status, do these changes make it back to the host object eventually. I haven't had a moment to test this out for myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those tests! I just got a chance to test it out and looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I spoke too soon, and there are failing tests. See: https://github.com/loft-sh/vcluster/actions/runs/16260609788/job/45935421118?pr=2729
…to ClusterIP/NodePort Signed-off-by: yujiel <yujiel@ebtech.com>
|
Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind test
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves #2728
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?