Skip to content

add entries for self in codeowners file #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

neogopher
Copy link
Contributor

What issue type does this pull request address? (keep at least one, remove the others)

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...

What else do we need to know?

@neogopher neogopher requested a review from a team as a code owner June 12, 2025 11:21
@nprokopic
Copy link
Contributor

Can we keep the file names sorted here? And ideally also grouped by top-level directory e.g.:

.github @person1 @person2

chart @person1 @person3

pkg/controllers @person3 @person4
pkg/controllers/<path> @person3 @person4
pkg/server @person3 @person5
pkg/syncer @person2 @person5
pkg/syncer/<path> <owners>

test/e2e @person3 @person5
test/e2e_node @person2 @person5

@@ -28,3 +28,8 @@ netlify.toml @loft-sh/Eng-Docs-Admin
/config/ @FabianKramm
/cmd/vcluster/ @FabianKramm
/chart/ @FabianKramm

cmd/vclusterctl/ @neogopher
config/ @neogopher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this will assign the ownership only to you, and remove it from Fabian (who added the same line above).

From GitHub docs:

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

So this should be:

config/ @FabianKramm @neogopher

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this document link. I will build my changes following the expected grouping and sorting based on your PR. 👍

@neogopher neogopher force-pushed the add-to-codeowners branch from 6185f50 to 0e9fa86 Compare June 13, 2025 12:59
@cbron
Copy link
Contributor

cbron commented Jul 11, 2025

@neogopher can you rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants