-
Notifications
You must be signed in to change notification settings - Fork 506
add entries for self in codeowners file #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can we keep the file names sorted here? And ideally also grouped by top-level directory e.g.:
|
.github/CODEOWNERS
Outdated
@@ -28,3 +28,8 @@ netlify.toml @loft-sh/Eng-Docs-Admin | |||
/config/ @FabianKramm | |||
/cmd/vcluster/ @FabianKramm | |||
/chart/ @FabianKramm | |||
|
|||
cmd/vclusterctl/ @neogopher | |||
config/ @neogopher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this will assign the ownership only to you, and remove it from Fabian (who added the same line above).
From GitHub docs:
If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.
So this should be:
config/ @FabianKramm @neogopher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to add the link to GitHub docs https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this document link. I will build my changes following the expected grouping and sorting based on your PR. 👍
6185f50
to
0e9fa86
Compare
@neogopher can you rebase |
What issue type does this pull request address? (keep at least one, remove the others)
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)resolves #
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?