-
Notifications
You must be signed in to change notification settings - Fork 10
[CLOUD-785] Refactor backups #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4397cf8 to
7c232ad
Compare
…defined use global value instead
…is created from within the helm installation as well
…t overriden globally
kouzant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maismail can you also write an example values file where backups are enabled and the metadata ConfigMap is set?
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| # FIXME add a default value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to address that in this patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot about it, done
Fixes https://hopsworks.atlassian.net/browse/CLOUD-785
Fixes https://hopsworks.atlassian.net/browse/HWORKS-2433