fix: allow removal of v2 volume head's parent #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
2 times, most recently
from
f332f35 to
69a3162
Compare
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
69a3162 to
38e47b9
Compare
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
2 times, most recently
from
38e47b9 to
b7c231a
Compare
derekbit
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
b7c231a to
f2c2778
Compare
Signed-off-by: Caio Torres <caio.torres@suse.com>
yulken
force-pushed
the
bugfix/delete-parent-v2-volume-head
branch
from
f2c2778 to
d06cae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9064
What this PR does / why we need it:
Disabling validation this so we can delete the parent of a v2 volume head.
Special notes for your reviewer:
Additional documentation or context
As commented on the code:
"SPDK allows deleting the parent of the volume head. To make the behavior consistent between v1 and v2 engines, we manually disable if for now."