-
-
Notifications
You must be signed in to change notification settings - Fork 93
[Bugfix] 4.2.3 - Update grace days on subscription renew #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 11.x Compatibility
Laravel 12.x Compatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
============================================
+ Coverage 97.84% 97.89% +0.04%
- Complexity 152 154 +2
============================================
Files 26 26
Lines 511 522 +11
============================================
+ Hits 500 511 +11
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
Subscription
model and its corresponding tests to handle thegrace_days
feature more effectively. The most important changes include updating therenew
method inSubscription
to set thegrace_days_ended_at
attribute and adding tests to ensure this functionality works correctly.Enhancements to
Subscription
model:src/Models/Subscription.php
: Updated therenew
method to set thegrace_days_ended_at
attribute based on the plan'sgrace_days
value.Tests for
grace_days
feature:tests/Models/SubscriptionTest.php
: AddedtestModelUpdatesGraceDaysEndedAtWhenRenewing
to verify thatgrace_days_ended_at
is correctly updated when renewing a subscription.tests/Models/SubscriptionTest.php
: AddedtestModelLeavesGraceDaysEmptyWhenRenewingIfPlanDoesNotHaveIt
to ensuregrace_days_ended_at
remains null if the plan does not have grace days.