[Hotfix] Renewed expiration delta bug #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of date differences and recurrence calculations in the
PeriodicityTypeandHandlesRecurrenceclasses. Additionally, new test cases have been added to ensure the correctness of these calculations.Improvements to date difference calculation:
src/Enums/PeriodicityType.php: Modified thegetDateDifferencemethod to handle cases where the start date is after the end date, ensuring the difference is always positive and adjusting the result based on the order of the dates.Enhancements to recurrence calculation:
src/Models/Concerns/HandlesRecurrence.php: Updated thecalculateNextRecurrenceEndmethod to use the modifiedgetDateDifferencemethod and ensure the number of recurrences is non-negative.Addition of new test cases:
tests/Models/Concerns/HandlesRecurrenceTest.php: Added multiple test cases to verify the correct calculation of the next recurrence end date under various scenarios, including renewals after one month, multiple renewals within a month, and renewals after expiration.