[Feature] Improvements for subscriptions with no expiration #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refines subscription handling by improving the logic for expiration and overdue status, and adds corresponding test cases to ensure correctness. The key changes include adjustments to how expiration dates are determined, handling of overdue status, and new tests to validate these behaviors.
Subscription expiration logic improvements:
subscribeTo
method inHasSubscriptions.php
to set expiration tonull
explicitly if the plan lacks periodicity, and adjusted grace days calculation to account for the absence of expiration.Overdue status handling:
getIsOverdueAttribute
inSubscription.php
to returnfalse
if the subscription has no expiration date, ensuring overdue logic is only applied when relevant.New test cases:
testItUsesReceivedExpirationEvenIfThePlanHasNoPeriodicity
inHasSubscriptionsTest.php
to verify that an explicitly provided expiration date is respected even when the plan lacks periodicity.testModelDoesNotRegisterOverdueIfThereIsNoExpiration
inSubscriptionTest.php
to confirm that overdue status is not marked if the subscription has no expiration date.