Fix --dump-toc-raw option #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was reading the correct number of bytes but from the wrong starting offset within the xar file. The --dump-toc-raw option always read at least the first sizeof(xar_header_ex_t) bytes from the file before reading header.toc_length_compressed bytes of data for the TOC header. However, sizeof(xar_header_ex_t) is the _maximum_ possible size of the header. The minimum size is sizeof(xar_header_t). The option then reads any additional bytes needed to position the fd at header.size bytes from the beginning of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was reading the correct number of bytes but
from the wrong starting offset within the xar file.
The --dump-toc-raw option always read at least the
first sizeof(xar_header_ex_t) bytes from the file before
reading header.toc_length_compressed bytes of data for
the TOC header.
However, sizeof(xar_header_ex_t) is the maximum possible
size of the header. The minimum size is sizeof(xar_header_t).
The option then reads any additional bytes needed to position
the fd at header.size bytes from the beginning of the file.