Fix cppauto deduction #1074
Merged
Fix cppauto deduction #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Perfect. Thanks a lot @Qubitol after the ci has run through please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1068.
With these changes, when selecting
cppautowe check from the most vectorised (avx512vl) option going through all lower vectorisation levels progressively (avx2,sse4_2) until we find one that is supported.We fallback to
cppnoneif nothing compatible is found.This allows deducing
cppautoin a very robust way, covering cases like Ivy Bridge microarchitecture (supportsavx, but notavx2, and in this case the deduction would selectcppsse4, and notcppavx2like it was happening before - eventually crashing).