chore: make a demo of dynamic services #139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienwebdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demo of an idea I had while reviewing code from @gowrizrh @danslo and @vpodorozh as well as @jissereitsma and @sprankhub in the context of #97 and #14 as well https://github.com/mage-os/infrastructure/blob/main/.github/workflows/unit-tests.yml
You can see in my fork that this actually works!
I really really really hate the duplication of:
serviceschunkthat we all have across various actions. For the "same command" that's just maintenance. For the services, I always thought that is just "how it is" and that we have to deal with it, however, it doesn't have to be, as I've just discovered.
We can leverage the same ideas I did with
supported-versionsto encapsulate all thatserviceslogic setup logic.This doesn't use
wardenbut perhaps we could work with the @navarr to come up with something similar?