Skip to content

2080: thread context was already set fix #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 30 commits into
base: 5.4.0-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
9dbe896
2080: Thread context was already set
VitaliyBoyko May 24, 2025
f0ba6c3
2080: removed ok and cancels
VitaliyBoyko May 24, 2025
be386bd
2080: Add custom dialogs to generate new Magento 2 classes
VitaliyBoyko May 24, 2025
1cdaafc
2080: adds a new action to generate a Magento 2 EAV customer attribut…
VitaliyBoyko May 24, 2025
5cafb40
2080: Implemented new action for generating EAV Product attribute wit…
VitaliyBoyko May 24, 2025
5921c02
2080: bumped up version
VitaliyBoyko May 24, 2025
728a40a
Code style fixes
VitaliyBoyko May 26, 2025
01a3f3c
2880: Refactor code formatting for improved readability
VitaliyBoyko May 26, 2025
b86cf57
2880: Remove unused Swing imports and simplify dialog classes
VitaliyBoyko May 26, 2025
9649908
2880: static fixes
VitaliyBoyko May 26, 2025
4deb987
2880: static fixes 2
VitaliyBoyko May 26, 2025
e9fe89c
2880: static fixes 3
VitaliyBoyko May 26, 2025
5424030
2880: static fixes 4
VitaliyBoyko May 26, 2025
588a321
2880: static fixes 5
VitaliyBoyko May 26, 2025
03f9003
2880: static fixes 6
VitaliyBoyko May 26, 2025
771260f
2880: static fixes 7
VitaliyBoyko May 26, 2025
2ee1355
2080: bumped up version of phpstorm
VitaliyBoyko Jun 1, 2025
f3b22e7
2080: updated SharedSteps.kt asn gradle plugin version
VitaliyBoyko Jun 1, 2025
117e67f
2080: removed license activation
VitaliyBoyko Jun 1, 2025
03df6c8
2080: fixed UI tests
VitaliyBoyko Jun 8, 2025
90b2f5e
2080: debug
VitaliyBoyko Jun 8, 2025
0ec28cb
2080: debug 2
VitaliyBoyko Jun 8, 2025
6d7fa79
Removed UI tests, since there is no way to get license for CI
VitaliyBoyko Aug 2, 2025
7170c3f
Fixed tests
VitaliyBoyko Aug 2, 2025
aa7f733
Updated gradle.properties
VitaliyBoyko Aug 2, 2025
a4dfdd4
Adjusted new entity dialog
VitaliyBoyko Aug 2, 2025
632a103
Adjusted new entity dialog
VitaliyBoyko Aug 2, 2025
76b1931
Static fixes
VitaliyBoyko Aug 2, 2025
dfcb199
Static fixes 2
VitaliyBoyko Aug 2, 2025
9e2dd92
Removed mocker
VitaliyBoyko Aug 2, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 40 additions & 2 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,50 @@ jobs:
run: chmod +x gradlew
- id: file_changes
uses: trilom/file-changes-action@v1.2.4
- name: Filter Java Files
id: filter_java_files
run: |
# Get modified and added files
MODIFIED_FILES=${{ steps.file_changes.outputs.files_modified }}
ADDED_FILES=${{ steps.file_changes.outputs.files_added }}

echo "Modified files: $MODIFIED_FILES"
echo "Added files: $ADDED_FILES"

# Simple approach using shell commands to filter Java files
# Remove brackets and quotes from the JSON arrays
MODIFIED_FILES=$(echo "$MODIFIED_FILES" | sed 's/^\[//;s/\]$//;s/"//g;s/,/ /g')
ADDED_FILES=$(echo "$ADDED_FILES" | sed 's/^\[//;s/\]$//;s/"//g;s/,/ /g')

# Combine the files and filter for .java files
ALL_FILES="$MODIFIED_FILES $ADDED_FILES"
JAVA_FILES=""

# If there are files to process
if [ ! -z "$ALL_FILES" ]; then
# Filter for Java files and format as JSON array
for file in $ALL_FILES; do
if [[ "$file" == *.java ]]; then
if [ -z "$JAVA_FILES" ]; then
JAVA_FILES="\"$file\""
else
JAVA_FILES="$JAVA_FILES,\"$file\""
fi
fi
done
fi

# Create a proper JSON array
JAVA_FILES="[$JAVA_FILES]"

echo "JAVA_FILES=$JAVA_FILES" >> $GITHUB_ENV
echo "Filtered Java Files: $JAVA_FILES"
- name: Run Code Style Check
run: ./gradlew checkstyleCI --no-daemon
env:
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}
MODIFIED_FILES: ${{ env.JAVA_FILES }}
ACTIONS_STEP_DEBUG: true
- name: Run PMD Quality Check
run: ./gradlew pmdCI --no-daemon
env:
MODIFIED_FILES: ${{ steps.file_changes.outputs.files}}
MODIFIED_FILES: ${{ env.JAVA_FILES }}
84 changes: 0 additions & 84 deletions .github/workflows/uitests.yml

This file was deleted.

7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0).

## 2025.2.0

### Fixed

- Thread context was already set [#2550](https://github.com/magento/magento2-phpstorm-plugin/pull/2550)
- Argument for @NotNull parameter 'psiDirectory' [#2553](https://github.com/magento/magento2-phpstorm-plugin/pull/2553)

## 2025.1.1

### Fixed
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<p style="margin: 10px 0;">Thank you to our sponsors—your support means everything:</p>
<p><strong>Lucas van Staden</strong></p>
<p><strong>Ivan Chepurnyi</strong></p>
<p><strong>Michael Ryvlin</strong></p>
</td>
</tr>
</tfoot>
Expand Down
6 changes: 3 additions & 3 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ repositories {

intellijPlatform {
defaultRepositories()
maven("https://www.jetbrains.com/intellij-repository/snapshots")
}
}

Expand All @@ -51,12 +52,9 @@ dependencies {

bundledPlugins(providers.gradleProperty("platformBundledPlugins").map { it.split(',') })
plugins(providers.gradleProperty("platformPlugins").map { it.split(',') })
plugin("com.intellij.lang.jsgraphql", "243.21565.122")
pluginVerifier()
zipSigner()
testFramework(TestFrameworkType.Platform)

phpstorm("2024.3")
}
}

Expand Down Expand Up @@ -174,6 +172,8 @@ intellijPlatformTesting {
"-Dide.mac.message.dialogs.as.sheets=false",
"-Djb.privacy.policy.text=<!--999.999-->",
"-Djb.consents.confirmation.enabled=false",
"-Deap.require.license=true",
"-Dide.show.tips.on.startup.default.value=false"
)
}
}
Expand Down
11 changes: 11 additions & 0 deletions check_modified.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/bash

# Get the list of modified files
MODIFIED_FILES=$(git diff --name-only HEAD | grep -E '\.java$' | sed 's/^/"/;s/$/"/' | tr '\n' ',' | sed 's/,$//')
MODIFIED_FILES="[$MODIFIED_FILES]"

# Export the environment variable
export MODIFIED_FILES

# Run the checkstyle and PMD tasks
./gradlew checkstyleCI pmdCI
8 changes: 4 additions & 4 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
pluginGroup = com.magento.idea.magento2plugin
pluginName = Magento PhpStorm
pluginRepositoryUrl = https://github.com/magento/magento2-phpstorm-plugin
pluginVersion = 2025.1.1
pluginSinceBuild = 243.3
pluginVersion = 2025.2.0
pluginSinceBuild = 250.*
pluginUntilBuild = 258.*
platformType = PS
platformVersion = 2024.3
platformPlugins =
platformVersion = 2025.1.4.1
platformPlugins = com.intellij.lang.jsgraphql:251.26927.39,org.jetbrains.junie:251.204.104
platformBundledPlugins = com.intellij.modules.json,com.jetbrains.php,JavaScript,com.intellij.copyright
gradleVersion = 8.10.2
kotlin.stdlib.default.dependency = false
Expand Down
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ junit = "4.13.2"

# plugins
changelog = "2.2.1"
intelliJPlatform = "2.4.0"
kotlin = "1.9.25"
intelliJPlatform = "2.7.0"
kotlin = "2.1.0"
kover = "0.8.3"
qodana = "2024.2.3"

Expand Down

This file was deleted.

Loading
Loading