Add support for a Header differentiating proxied and non proxied Requests to UPWARD-PHP #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2022 10:59
… proxied though upward-php
|
hi |
yusufpangal
reviewed
Jul 14, 2025
| $this->scopeConfig->getValue( | ||
| self::UPWARD_CONFIG_PATH_FRONT_NAMES_TO_SKIP, | ||
| ScopeInterface::SCOPE_STORE | ||
| ) ?? '' |
There was a problem hiding this comment.
Retrieving environment variable. Consider if this could be fetched once (e.g., in constructor) if method is frequently called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution to #44
If the new environment variable is not defined, the result is the same as previously.
Still requires the addition of said Header to https://github.com/magento/upward-php in the proxy request.