Skip to content

Update core_utils.py #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update core_utils.py #295

wants to merge 1 commit into from

Conversation

GabrielCabas
Copy link

@GabrielCabas GabrielCabas commented Jan 21, 2025 •
edited
Loading

Early stopping isn't working. It's because it is an "and" instead of "or" on line 78. This commit fixes it.

@GabrielCabas
Update core_utils.py
cc1282f 
The early stopping isn't working. It's because it is an and instead an or in the line 78.
Borda
Borda approved these changes Feb 11, 2025
View reviewed changes
Copy link

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense :)
cc: @HHenryD

@GabrielCabas GabrielCabas reopened this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Borda Borda Borda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GabrielCabas @Borda