Skip to content

Conversation

@tivvie
Copy link

@tivvie tivvie commented Sep 17, 2025

PHP message: PHP Deprecated:
MailerLite\LaravelElasticsearch\Manager::connection(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead

Changelog entries:
https://www.php.net/manual/en/migration84.deprecated.php

Thank you for helping to make this package better!

Please make sure you've read CONTRIBUTING.md
before submitting your pull request, and that you have:

  • provided a rationale for your change (I try not to add features that are going to have a limited user-base)
  • used the PSR-2 Coding Standard
  • added tests
  • documented any change in behaviour (e.g. updated the README.md, etc.)
  • only submitted one pull request per feature

Thank you!

PHP message: PHP Deprecated:
MailerLite\LaravelElasticsearch\Manager::connection():
Implicitly marking parameter $name as nullable is deprecated,
the explicit nullable type must be used instead

Changelog entries:
https://www.php.net/manual/en/migration84.deprecated.php
@tivvie tivvie changed the title Fix PHP84 deprecation Fix PHP 8.4 deprecation Sep 17, 2025
Copy link

@gord007 gord007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK, pls merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants