Skip to content

avoid double String allocation #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: solutions
Choose a base branch
from
Open

avoid double String allocation #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions exercises/05_ticket_v2/15_outro/src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ impl TryFrom<String> for Status {
type Error = ParseStatusError;

fn try_from(value: String) -> Result<Self, Self::Error> {
value.try_into()
}
}

impl TryFrom<&str> for Status {
type Error = ParseStatusError;

fn try_from(value: &str) -> Result<Self, Self::Error> {
let value = value.to_lowercase();
match value.as_str() {
"todo" => Ok(Status::ToDo),
Expand All @@ -24,14 +32,6 @@ impl TryFrom<String> for Status {
}
}

impl TryFrom<&str> for Status {
type Error = ParseStatusError;

fn try_from(value: &str) -> Result<Self, Self::Error> {
value.to_lowercase().try_into()
}
}

#[derive(Debug, thiserror::Error)]
#[error("`{invalid_status}` is not a valid status. Use one of: ToDo, InProgress, Done")]
pub struct ParseStatusError {
Expand Down