Skip to content

Conversation

@makspll
Copy link
Owner

@makspll makspll commented Nov 7, 2025

Guess not many people use this path and I didn't notice

@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 7, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/languages/bevy_mod_scripting_lua/src/bindings/script_value.rs  0% smaller

@makspll makspll enabled auto-merge (squash) November 7, 2025 00:57
@makspll makspll changed the title fix: remove print fix: remove unnecessary print Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

🐰 Bencher Report

Branchmakspll-patch-1
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,889.90 ns
(-11.18%)Baseline: 4,379.55 ns
4,968.47 ns
(78.29%)
component/access Rhai📈 view plot
🚷 view threshold
5,507.40 ns
(-9.28%)Baseline: 6,070.56 ns
6,690.66 ns
(82.31%)
component/get Lua📈 view plot
🚷 view threshold
2,513.00 ns
(-11.04%)Baseline: 2,824.80 ns
3,238.79 ns
(77.59%)
component/get Rhai📈 view plot
🚷 view threshold
4,292.60 ns
(-6.60%)Baseline: 4,595.81 ns
5,036.41 ns
(85.23%)
conversions/Mut::from📈 view plot
🚷 view threshold
92.59 ns
(-9.63%)Baseline: 102.46 ns
121.22 ns
(76.38%)
conversions/Ref::from📈 view plot
🚷 view threshold
86.28 ns
(-12.19%)Baseline: 98.25 ns
116.25 ns
(74.21%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
372.37 ns
(-3.37%)Baseline: 385.35 ns
444.09 ns
(83.85%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,004.20 ns
(-14.18%)Baseline: 1,170.09 ns
1,373.75 ns
(73.10%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
27.31 ns
(-3.92%)Baseline: 28.42 ns
31.03 ns
(87.99%)
conversions/Val::from_into📈 view plot
🚷 view threshold
266.26 ns
(-15.00%)Baseline: 313.26 ns
395.57 ns
(67.31%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,884.30 ns
(-10.08%)Baseline: 2,095.43 ns
2,433.28 ns
(77.44%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,356.20 ns
(-11.10%)Baseline: 1,525.53 ns
1,711.13 ns
(79.26%)
function/call Lua📈 view plot
🚷 view threshold
389.37 ns
(+0.71%)Baseline: 386.61 ns
598.70 ns
(65.04%)
function/call Rhai📈 view plot
🚷 view threshold
479.88 ns
(+0.69%)Baseline: 476.58 ns
541.73 ns
(88.58%)
loading/empty Lua📈 view plot
🚷 view threshold
875,580.00 ns
(-12.14%)Baseline: 996,539.00 ns
1,261,565.43 ns
(69.40%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,041,000.00 ns
(-15.43%)Baseline: 1,230,974.00 ns
1,684,215.71 ns
(61.81%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
7,241.50 ns
(-12.32%)Baseline: 8,259.40 ns
9,364.57 ns
(77.33%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,616.50 ns
(-9.67%)Baseline: 7,324.64 ns
8,209.23 ns
(80.60%)
query/10 entities Lua📈 view plot
🚷 view threshold
20,572.00 ns
(-14.16%)Baseline: 23,965.50 ns
27,885.94 ns
(73.77%)
query/10 entities Rhai📈 view plot
🚷 view threshold
19,494.00 ns
(-11.18%)Baseline: 21,947.10 ns
24,557.35 ns
(79.38%)
query/100 entities Lua📈 view plot
🚷 view threshold
41,026.00 ns
(-11.44%)Baseline: 46,325.80 ns
52,259.28 ns
(78.50%)
query/100 entities Rhai📈 view plot
🚷 view threshold
31,962.00 ns
(-11.34%)Baseline: 36,048.30 ns
40,912.78 ns
(78.12%)
query/1000 entities Lua📈 view plot
🚷 view threshold
289,350.00 ns
(-4.85%)Baseline: 304,089.00 ns
355,505.56 ns
(81.39%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
159,950.00 ns
(-13.90%)Baseline: 185,765.00 ns
223,751.84 ns
(71.49%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,578.20 ns
(-9.88%)Baseline: 6,189.84 ns
6,819.62 ns
(81.80%)
reflection/10 Rhai📈 view plot
🚷 view threshold
14,773.00 ns
(-7.16%)Baseline: 15,911.90 ns
17,041.40 ns
(86.69%)
reflection/100 Lua📈 view plot
🚷 view threshold
47,212.00 ns
(-10.13%)Baseline: 52,532.90 ns
58,464.89 ns
(80.75%)
reflection/100 Rhai📈 view plot
🚷 view threshold
718,320.00 ns
(-8.88%)Baseline: 788,318.00 ns
860,824.67 ns
(83.45%)
resource/access Lua📈 view plot
🚷 view threshold
3,518.80 ns
(-11.36%)Baseline: 3,969.87 ns
4,432.92 ns
(79.38%)
resource/access Rhai📈 view plot
🚷 view threshold
5,002.70 ns
(-9.60%)Baseline: 5,533.73 ns
6,126.25 ns
(81.66%)
resource/get Lua📈 view plot
🚷 view threshold
2,092.60 ns
(-14.16%)Baseline: 2,437.84 ns
2,944.94 ns
(71.06%)
resource/get Rhai📈 view plot
🚷 view threshold
3,789.60 ns
(-7.71%)Baseline: 4,106.37 ns
4,520.02 ns
(83.84%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit 446a6c7 into main Nov 7, 2025
29 of 31 checks passed
@makspll makspll deleted the makspll-patch-1 branch November 7, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants