Skip to content

Use <button> for keyboard accessibility #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albell wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use <button> for keyboard accessibility #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b16bc38
Use <button> for keyboard accessibility
albell Apr 29, 2014
ab0e817
throttle initAutoHeight triggered by slide-added
albell May 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/jquery.cycle2.autoheight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ $(document).on( 'cycle-initialized', function( e, opts ) {
return;

// bind events
opts.container.on( 'cycle-slide-added cycle-slide-removed', initAutoHeight );
opts.container.on( 'cycle-destroyed', onDestroy );

if ( autoHeight == 'container' ) {
Expand All @@ -31,15 +30,15 @@ $(document).on( 'cycle-initialized', function( e, opts ) {
opts._autoHeightRatio = ratio;
}

// if autoHeight is a number then we don't need to recalculate the sentinel
// index on resize
// if autoHeight is calc or ratio then we need to recalculate the sentinel
// index on resize, and also on slide-added/slide-removed
if ( t !== 'number' ) {
// bind unique resize handler per slideshow (so it can be 'off-ed' in onDestroy)
opts._autoHeightOnResize = function () {
clearTimeout( resizeThrottle );
resizeThrottle = setTimeout( onResize, 50 );
};

opts.container.on( 'cycle-slide-added cycle-slide-removed', opts._autoHeightOnResize );
$(window).on( 'resize orientationchange', opts._autoHeightOnResize );
}

Expand Down
2 changes: 1 addition & 1 deletion src/jquery.cycle2.pager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ $.extend($.fn.cycle.defaults, {
pagerActiveClass: 'cycle-pager-active',
pagerEvent: 'click.cycle',
pagerEventBubble: undefined,
pagerTemplate: '<span>&bull;</span>'
pagerTemplate: '<button>&bull;</button>'
});

$(document).on( 'cycle-bootstrap', function( e, opts, API ) {
Expand Down