Add Spain Flag #25
Add Spain Flag #25
Conversation
|
@josevill Hey! 😄 This looks great! I'm not sure if it is valid though. If you can share some related source, it would be great! Also, please update the README.md file as per Contributions guidelines. |
|
@manrajgrover Hi there. Here's some related info about the flag. https://en.wikipedia.org/wiki/Flag_of_Spain |
|
@manrajgrover Done :) |
Flags/Spain.html
Outdated
| #spain { | ||
| width: 150px; | ||
| height: 92px; | ||
| background: linear-gradient(180deg, #d03e3e 0%, #d03e3e 25%, #ffc100 25%, #ffc100 75%, #d03e3e 75%, #d03e3e 100%); } |
There was a problem hiding this comment.
Nit: There is an extra closing bracket here. Please fix it.
|
@josevill Awesome. I have left 1 small nit. Please fix it. Also, please resolve merge conflicts, so that we can merge it. 😊 |
|
@josevill Please resolve merge conflicts too. :) |
|
I think i have to do this from the computer. I'm new to this kind of stuff haha |
|
@josevill No rushes. Great opportunity to learn. :D |
|
@manrajgrover After uhhh almost 3 years, this is now updated :) 👍 |
2 participants
It's valid to use this one without the coat of arms.