First draft of FAIR Mappings schema #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces new YAML files under tests/data/valid and tests/data/invalid to provide examples of both valid and invalid MappingSpecification objects. These files can be used for testing schema validation and error handling.
Introduces new classes (Agent, Source, MappingSpecification) and associated slots to the fair_mappings_schema.yaml.
|
Introduced AgentTypeEnum, SourceTypeEnum, and MappingSpecificationTypeEnum to define permissible values for agent, source, and mapping specification types. Updated the Agent, Source, and MappingSpecification classes to use these enums via slot_usage. Added new slots for version, type, and reviewer to relevant classes to enhance schema expressiveness.
Removed AgentTypeEnum and refactored Agent into abstract class with Person, Organization, and Software subclasses. Added new slots for agent subclasses and extended MappingTypeEnum with yarrrml and xslt options.
Replaces 'content' with 'content_url' in Source and MappingSpecification classes and updates all related YAML and test files. Adds 'metadata_url' and 'metadata_type' fields to Source for improved metadata handling.
jkesanie
reviewed
Oct 24, 2025
|
|
||
| MappingSpecificationTypeEnum: | ||
| description: Types of mapping specifications | ||
| permissible_values: |
There was a problem hiding this comment.
We should add "shacl-rules" to the enum.
jkesanie
reviewed
Oct 24, 2025
| - linkml:types | ||
|
|
||
| enums: | ||
| SourceTypeEnum: |
There was a problem hiding this comment.
I think we should either have specific definition languages (e.g. owl, skos etc) in all of the values or none of them. I would prefer this be a high level type i.e. ontology, database, vocabulary etc. We should another field for the specific definition language (or representation technique as ADMS puts it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.